Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

[Rusty Russell]

"Michael S. Tsirkin" <address@hidden> writes:
> On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote:
>> "Michael S. Tsirkin" <address@hidden> writes:
>> > virtio 1.0 config space is in LE format for all
>> > devices, use modern wrappers when accessed through
>> > the 1.0 BAR.
>> 
>> Hmm, I'm not so sure about these patches.  It's easy to miss the
>> existence of the _modern variants, and they're 90% the same as the
>> legacy variants.
>> 
>> But as long as it's fixed...
>> 
>> Thanks,
>> Rusty.
>> PS.  rng, block, net and 9p virtio 1.0 seem to work OK on BE guests (LE 
>> host).
>
> Hmm good point. What if I'll rework this to get bool legacy parameter?

The functions have access to vdev, so they can determine that already.

Simply renaming the old version to _legacy would be enough.

Thanks,
Rusty.