[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case
Date: Wed, 04 Mar 2015 09:13:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2015-03-04 at 09:12, Kevin Wolf wrote:
Am 04.03.2015 um 14:58 hat Max Reitz geschrieben:
On 2015-03-04 at 07:23, Kevin Wolf wrote:
Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben:
commit "BlockConf: Call backend functions to detect geometry and
blocksizes" causes a segmentation fault on the invalid configuration of
a scsi device without a drive.

Lets check for conf.blk before calling blkconf_blocksizes. The error
will be handled later on in scsi_realize anyway.

Reported-by: Max Reitz <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: Ekaterina Tumanova <address@hidden>
Thanks, added the commit ID of the regression to the commit message, and
applied to the block branch.
But that commit is not yet upstream, so the ID won't be stable. Are
you planning to change it once it's merged?
Unless someone touches the pull request (which he shouldn't), the commit
ID is going to stay.

Oh, that's nice, I didn't know that. Thanks for explaining.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]