[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the time

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the timers asap like a bottom half
Date: Tue, 3 Mar 2015 11:08:53 -0600
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Feb 13, 2015 at 06:06:14PM +0200, Alberto Garcia wrote:
> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> index 69aa7c2..f846e5a 100644
> --- a/include/qemu/throttle.h
> +++ b/include/qemu/throttle.h
> @@ -127,6 +127,8 @@ bool throttle_schedule_timer(ThrottleState *ts,
>                               bool is_write,
>                               bool *armed);
> +void throttle_fire_timer(ThrottleTimers *tt, bool is_write);
> +
>  void throttle_timer_fired(ThrottleState *ts, bool is_write);
>  void throttle_account(ThrottleState *ts, bool is_write, uint64_t size);

General feeling when seeing this patch:

This is a little weird because suddenly we're dealing directly with
ThrottleTimers instead of ThrottleState or ThrottleGroup.  Also, it
doesn't set any_timers_pending[], maybe that could be a problem.

Attachment: pgpAQbuY4H9_3.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]