[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type

From: Michael Mueller
Subject: Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none
Date: Tue, 3 Mar 2015 11:23:35 +0100

On Mon, 2 Mar 2015 16:17:33 -0300
Eduardo Habkost <address@hidden> wrote:

> > +        if (probe_mode) {
> > +            /* Use these accelerators in probe mode, tcg should be last */
> > +            p = probe_mode_accels;  
> I don't fully understand the purpose of this patch yet (I will discuss
> it in a reply to the cover letter). But if you really want -machine none
> to trigger different behavior, why you didn't add a probe_mode field
> to MachineClass, so you can set it in the mahine_none class code?

I initially had this machine attribute but, when I remember correctly, but 
wasn't able to
communicate it down into the target code. But anyhow, the "mode" is eventually 
obsolete in light
of the temporarily constructed accelerators.. I will further comment on this as 
reply to your
comment on the cover letter to keep it in place.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]