[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for

From: Brad Campbell
Subject: Re: [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices
Date: Tue, 03 Mar 2015 09:36:00 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/03/15 00:09, Gerd Hoffmann wrote:
Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
update_displaychangelistener call sites:

Two for primary qxl cards, when entering/leaving vga mode, which are

One for secondary qxl cards, which is wrong because we don't register
a displaychangelistener in the first place for secondary cards.

Remove it.

Reported-by: Brad Campbell <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Brad Campbell <address@hidden>

  hw/display/qxl.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 94ff52a..762f75d 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d)
      } else {
          d->mode = QXL_MODE_UNDEFINED;
-        update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE);

Many thanks for the rapid response Gerd.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]