Re: [Qemu-devel] [PATCH 2/2] Makefile.target: binary depends on config-devices

[Paolo Bonzini]

On 19/02/2015 08:48, Michael S. Tsirkin wrote:
> relink binary whenever config-devices.mak changes:
> this makes sense as we are adding/removing devices,
> so binary has to be relinked to be up to date.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  Makefile.target | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 58c6ae1..2262d89 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -175,9 +175,11 @@ all-obj-y += $(common-obj-y)
>  all-obj-y += $(target-obj-y)
>  all-obj-$(CONFIG_SOFTMMU) += $(block-obj-y)
>  
> +$(QEMU_PROG_BUILD): config-devices.mak
> +
>  # build either PROG or PROGW
>  $(QEMU_PROG_BUILD): $(all-obj-y) ../libqemuutil.a ../libqemustub.a
> -     $(call LINK,$^)
> +     $(call LINK, $(filter-out %.mak, $^))
>  
>  gdbstub-xml.c: $(TARGET_XML_FILES) $(SRC_PATH)/scripts/feature_to_c.sh
>       $(call quiet-command,rm -f $@ && $(SHELL) 
> $(SRC_PATH)/scripts/feature_to_c.sh $@ $(TARGET_XML_FILES),"  GEN   
> $(TARGET_DIR)$@")
> 

Not exactly beautiful, but I don't have any better idea.

Applied, thanks.

Paolo