[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support |
Date: |
Tue, 24 Feb 2015 09:47:56 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/24/2015 09:45 AM, Eric Blake wrote:
> On 02/13/2015 09:06 AM, Alberto Garcia wrote:
>> The throttle group support use a cooperative round robin scheduling
>> algorithm.
>>
>> qapi/block-core.json | 5 +-
>> qemu-options.hx | 1 +
>> qmp-commands.hx | 3 +-
>
> Just a qapi review for now...
>
>
> I hate write-only interfaces. What is the corresponding 'query-*'
> command that I can invoke to learn which group, if any, a node is
> associated with?
Okay, I hit send too soon. I see this is part of BlockDeviceInfo, which
is in turn part of BlockInfo returned by 'query-block'. So this
addition is the output side, and there is nothing that yet exists to
associate a node with a throttle group on the input side (assuming that
comes later in 8/9 or 9/9).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the timers asap like a bottom half, (continued)
- [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the timers asap like a bottom half, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 8/9] throttle: Update throttle infrastructure copyright, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 3/9] throttle: Add throttle group infrastructure tests, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 4/9] throttle: Prepare to have multiple timers for one ThrottleState, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 5/9] throttle: Add a way to know if throttle_schedule_timer had armed a timer, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 2/9] throttle: Add throttle group infrastructure, Alberto Garcia, 2015/02/13
- [Qemu-devel] [PATCH 1/9] throttle: Extract timers from ThrottleState into a separate ThrottleTimers structure, Alberto Garcia, 2015/02/13