[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 11/11] qemu-char: Avoid qerror_report_err() outsid
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v2 11/11] qemu-char: Avoid qerror_report_err() outside QMP command handlers |
Date: |
Wed, 18 Feb 2015 12:10:41 +0100 |
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in legacy chardev parser
qemu_chr_parse_compat(). Legacy chardev syntax is not to be used in
QMP.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qemu-char.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index f901ed1..8159462 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3306,8 +3306,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const
char *filename)
opts = qemu_opts_create(qemu_find_opts("chardev"), label, 1, &local_err);
if (local_err) {
- qerror_report_err(local_err);
- error_free(local_err);
+ error_report_err(local_err);
return NULL;
}
--
1.9.3
- [Qemu-devel] [PULL v2 00/11] Clean up around error_get_pretty(), qerror_report_err(), Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 02/11] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 10/11] qemu-img: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 01/11] vhost-scsi: Improve error reporting for invalid vhostfd, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 11/11] qemu-char: Avoid qerror_report_err() outside QMP command handlers,
Markus Armbruster <=
- [Qemu-devel] [PULL v2 04/11] monitor: Clean up around monitor_handle_fd_param(), Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 06/11] net: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 05/11] monitor: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 03/11] error: Use error_report_err() where appropriate, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 09/11] vl: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 07/11] numa: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/18
- [Qemu-devel] [PULL v2 08/11] tpm: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/18
- Re: [Qemu-devel] [PULL v2 00/11] Clean up around error_get_pretty(), qerror_report_err(), Peter Maydell, 2015/02/26