[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause |
Date: |
Tue, 17 Feb 2015 20:13:25 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Eric Blake (address@hidden) wrote:
> On 02/17/2015 07:59 AM, Amit Shah wrote:
> >>>
> >>> So the only comment I have is with the 'pause' name.
> >>>
> >>> 'pause' to me means there's a time period for which a pause has to be
> >>> done; or pausing an activity which is already in progress, both of
> >>> which are not true for this case.
> >>
> >> I think that pause and wait are both pretty similar; wait generally
> >> does mean wait for something specific though.
> >>
> >> The 'pause' button on your video player doesn't have an expectation
> >> of how long you will pause it.
> >
> > Right; but it pauses an already-playing video. We're not pausing an
> > incoming migration here; we're not even started.
> >
> > So pause in the migration world will make sense (to me, of course)
> > when we actually pause an ongoing migration...
>
> As long as we are bike-shedding, would 'defer' be any nicer, as an
> indication that we are deferring the actual migration until the QMP
> command starts it?
I'm happy with any of them (as I assume were those who R-b'd the set).
If people really think it needs to change then fine, I'm happy
to recut and retest it. But if it's just bike-shedding, then I'd
rather not.
Dave
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 1/3] Add -incoming pause, (continued)