[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring |
Date: |
Tue, 17 Feb 2015 08:27:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/16/2015 08:14 PM, Michael Roth wrote:
> From: Simon Zolin <address@hidden>
>
> Moved the code that sets non-blocking flag on fd into a separate function.
>
> Signed-off-by: Simon Zolin <address@hidden>
> Reviewed-by: Roman Kagan <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Michael Roth <address@hidden>
> CC: Eric Blake <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
> ---
> qga/commands-posix.c | 31 +++++++++++++++++++++++--------
> 1 file changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 57409d0..ed527a3 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -376,13 +376,33 @@ safe_open_or_create(const char *path, const char *mode,
> Error **errp)
> return NULL;
> }
>
> +static int guest_file_toggle_flags(int fd, int flags, bool set, Error **err)
> +{
Why are you reinventing qemu_set_nonblock()?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command, (continued)
- [Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 02/10] utils: drop strtok_r from envlist_parse, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 09/10] qga: add memory block command that unsupported, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 04/10] qga: implement file commands for Windows guest, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 07/10] qga: implement qmp_guest_set_memory_blocks() for Linux with sysfs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 06/10] qga: implement qmp_guest_get_memory_blocks() for Linux with sysfs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring, Michael Roth, 2015/02/16
[Qemu-devel] [PATCH 08/10] qga: implement qmp_guest_get_memory_block_size() for Linux with sysfs, Michael Roth, 2015/02/16
Re: [Qemu-devel] [PULL 00/10] Fixes and new commands for QEMU Guest Agent, Michael Roth, 2015/02/17