[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support
From: |
Scott Feldman |
Subject: |
Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support |
Date: |
Mon, 16 Feb 2015 17:37:23 -0500 |
On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 16/02/2015 22:47, address@hidden wrote:
>> From: Scott Feldman <address@hidden>
>>
>> Add QMP/HMP support for rocker devices. This is mostly for debugging
>> purposes
>> to see inside the device's tables and port configurations. Some examples:
>>
>> (qemu) info rocker sw1
>> name: sw1
>> id: 0x0000013512005452
>> ports: 4
>
> I think CONFIG_ROCKER doesn't work as intended. It's not exported to C
> files.
It's working fine. What do you think it broken?
> I would just merge the other nine patches for 2.3.
I disagree. qmp/hmp is very important to rocker. It would be nearly
impossible to debug large/complicated networking setups without having
a back-door view into the device. qmp/hmp are perfect for this.
Since rocker's primary purpose is for development of OS support for
traditional L2/L3 offloads as well as flow-based offloads, it is
important to enable this debug tool.
-scott
- [Qemu-devel] [PATCH v7 00/10] rocker: add new rocker ethernet switch device, sfeldma, 2015/02/16
- [Qemu-devel] [PATCH v7 04/10] pci: add rocker device ID, sfeldma, 2015/02/16
- [Qemu-devel] [PATCH v7 01/10] net: add MAC address string printer, sfeldma, 2015/02/16
- [Qemu-devel] [PATCH v7 02/10] virtio-net: use qemu_mac_strdup_printf, sfeldma, 2015/02/16
- [Qemu-devel] [PATCH v7 03/10] rocker: add register programming guide, sfeldma, 2015/02/16
- [Qemu-devel] [PATCH v7 05/10] pci: add network device class 'other' for network switches, sfeldma, 2015/02/16
- [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support, sfeldma, 2015/02/16
- Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support, Scott Feldman, 2015/02/16
[Qemu-devel] [PATCH v7 09/10] MAINTAINERS: add rocker, sfeldma, 2015/02/16
[Qemu-devel] [PATCH v7 08/10] rocker: add tests, sfeldma, 2015/02/16
[Qemu-devel] [PATCH v7 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM, sfeldma, 2015/02/16
[Qemu-devel] [PATCH v7 06/10] rocker: add new rocker switch device, sfeldma, 2015/02/16
Re: [Qemu-devel] [PATCH v7 00/10] rocker: add new rocker ethernet switch device, Stefan Hajnoczi, 2015/02/23