[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/7] vnc: fix coverity warning
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 7/7] vnc: fix coverity warning |
Date: |
Mon, 16 Feb 2015 09:26:05 +0100 |
vnc_display_local_addr will not be called with an invalid display id.
Add assert() to silence coverity warning about a null pointer dereference.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index 14289fd..10a2724 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3248,6 +3248,7 @@ char *vnc_display_local_addr(const char *id)
{
VncDisplay *vs = vnc_display_find(id);
+ assert(vs);
return vnc_socket_local_addr("%s:%s", vs->lsock);
}
--
1.8.3.1
- [Qemu-devel] [PULL 0/7] vnc: fixup some QemuOpts conversion fallout., Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 3/7] vnc: using bool type instead of int for QEMU_OPT_BOOL, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 1/7] vnc: fix qemu crash when not configure vnc option, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 7/7] vnc: fix coverity warning,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 2/7] vnc: correct missing property about vnc_display, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 5/7] vnc: auto assian an id when calling change vnc qmp interface, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 6/7] ui/vnc: optimize full scanline updates, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 4/7] vnc: introduce an wrapper for auto assign vnc id, Gerd Hoffmann, 2015/02/16
- Re: [Qemu-devel] [PULL 0/7] vnc: fixup some QemuOpts conversion fallout., Peter Maydell, 2015/02/24