[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM property |
|
Date: |
Tue, 10 Feb 2015 10:19:58 +0100 |
On Di, 2015-02-10 at 15:36 +1100, David Gibson wrote:
> The VGA device model now supports having the framebuffer in either endian,
> and can be switched between these by the guest via a register in the qext
> region.
>
> However, in some cases (e.g. LE OS on the pseries machine) we have
> existing guest that don't know about the endian switch register, but other
> parts of the qemu code have better information to set a default endianness
> than the VGA code does of itself.
>
> In order to allow them to set a correct default endianness in these cases,
> without breaking abstraction walls, this patch exposes the VGA framebuffer
> endianness via a writable QOM property.
>
> Signed-off-by: David Gibson <address@hidden>
>
> prop fixup
squash leftover?
Otherwise:
Reviewed-by: Gerd Hoffmann <address@hidden>
(assuming this little series gets in via ppc tree).
cheers,
Gerd