Re: [Qemu-devel] [PATCH v3 04/19] libqos/ahci: Add command header helpers

[Stefan Hajnoczi]

On Thu, Feb 05, 2015 at 12:41:15PM -0500, John Snow wrote:
> Adds command header helper functions:
> -ahci_command_header_set
> -ahci_command_header_get,
> -ahci_command_destroy, and
> -ahci_cmd_pick
> 
> These helpers help to quickly manage the command header information in
> the AHCI device.
> 
> ahci_command_header_set and get will store or retrieve an AHCI command
> header, respectively.
> 
> ahci_cmd_pick chooses the first available but least recently used
> command slot to allow us to cycle through the available command slots.
> 
> ahci_command_destroy obliterates all information contained within a
> given slot's command header, and frees its associated command table,
> but not its DMA buffer!
> 
> Lastly, the command table pointer fields (dba and dbau) are merged into
> a single 64bit value to make managing 64bit tests simpler.
> 
> Signed-off-by: John Snow <address@hidden>
> ---
>  tests/ahci-test.c   | 43 ++++++++++++++++--------------
>  tests/libqos/ahci.c | 75 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/ahci.h | 17 ++++++++----
>  3 files changed, 110 insertions(+), 25 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpHjIIct53Gr.pgp
Description: PGP signature