[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect() |
Date: |
Thu, 05 Feb 2015 13:42:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/05/2015 11:58 AM, Max Reitz wrote:
> As part of the required changes, this fixes a bug where specifying an
> invalid driver would result in the block layer probing the image format;
> now it will result in an error, unless "<unset>" is specified as the
> driver name. Fixing this would require further work on the xen_disk code
> which does not seem worth it (at this point and for this patch).
With enough hand-waving in the commit message, you can justify
practically any partial fix :)
Strictly better than pre-patch, and I agree that worrying about the
remaining warts is out of scope for this series.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> hw/block/xen_disk.c | 27 +++++++++++----------------
> 1 file changed, 11 insertions(+), 16 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init(), (continued)
- [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 08/16] qemu-img: Use blk_new_open() in img_rebase(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 02/16] block: Add blk_new_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 09/16] qemu-img: Use BlockBackend as far as possible, Max Reitz, 2015/02/05