[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was select
From: |
Don Slutz |
Subject: |
Re: [Qemu-devel] [PATCH] vl.c: fixed QEMU crash if no display was selected in command line |
Date: |
Wed, 04 Feb 2015 15:40:06 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
A proper fix for this is the thread:
Subject: [PATCH v2 0/3] fix qemu crash about vnc
Date: Fri, 30 Jan 2015 10:14:33 +0800
Message-ID: <address@hidden>
This also has a bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Xen expects this to be working.
-Don Slutz
On 02/04/15 06:25, Marcel Apfelbaum wrote:
> Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers)
> converted vnc option to QemuOpts.
> However, the default vnc display had ...,to=99,... between parameters
> that is not covered by the QemuOpts.
> Remove it because is not longer used and solves the crash.
>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
> This issue is bugging me some time now. Please let me know if
> I got it wrong.
>
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 983259b..c8f33d2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)
> #elif defined(CONFIG_SDL) || defined(CONFIG_COCOA)
> display_type = DT_SDL;
> #elif defined(CONFIG_VNC)
> - vnc_parse_func("localhost:0,to=99,id=default");
> + vnc_parse_func("localhost:0,id=default");
> show_vnc_port = 1;
> #else
> display_type = DT_NONE;
>