[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/9] s390x/pci: check for invalid function handle
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 3/9] s390x/pci: check for invalid function handle |
Date: |
Tue, 3 Feb 2015 14:08:42 +0100 |
From: Frank Blaschka <address@hidden>
broken guest may provide 0 (invalid) function handle to zpci
instructions. Since we use function handle 0 to indicate an empty
slot in the PHB we have to add an additional check to spot this
kind of error.
Signed-off-by: Frank Blaschka <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/s390-pci-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index d25ac74..dc455a2 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -170,7 +170,7 @@ S390PCIBusDevice *s390_pci_find_dev_by_fh(uint32_t fh)
S390pciState *s = S390_PCI_HOST_BRIDGE(
object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
- if (!s) {
+ if (!s || !fh) {
return NULL;
}
--
1.7.9.5
- [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 2/9] s390x/pci: avoid sign extension in stpcifc, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 1/9] s390: Plug memory leak on s390_pci_generate_event() error path, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 3/9] s390x/pci: check for invalid function handle,
Cornelia Huck <=
- [Qemu-devel] [PULL 4/9] s390x/pci: fix dma notifications in rpcit instruction, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 5/9] s390x/kvm: Fix diag-308 register decoding, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 7/9] s390x/ipl: Improved code indentation in s390_ipl_init(), Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 9/9] pc-bios/s390-ccw: update binary, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 6/9] s390x/kvm: unknown DIAGNOSE code should give a specification exception, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 8/9] pc-bios/s390-ccw: fix sparse warnings, Cornelia Huck, 2015/02/03
- Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups, Peter Maydell, 2015/02/03
- Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups, Peter Maydell, 2015/02/03