[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfil
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile() |
Date: |
Mon, 2 Feb 2015 20:34:02 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-io.c | 31 ++++++++++++-------------------
> 1 file changed, 12 insertions(+), 19 deletions(-)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index 91a445a..81f8f64 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -39,7 +39,6 @@ static ReadLineState *readline_state;
> static int close_f(BlockDriverState *bs, int argc, char **argv)
> {
> blk_unref(qemuio_blk);
> - qemuio_bs = NULL;
> qemuio_blk = NULL;
> return 0;
> }
This doesn't seem to be correct at this point in the series. qemuio_bs
is still passed to qemuio_command(), which checks whether non-global
commands are allowed to run using init_check_command().
At the end of the series, please remove qemuio_bs altogether. This
version of the series leaves it around without any reader.
Kevin
- Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile(),
Kevin Wolf <=