Re: [Qemu-devel] [PATCH v2 4/4] block: Eliminate silly QERR_ macros used for encryption keys

[Max Reitz]

On 2015-01-29 at 04:37, Markus Armbruster wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> They're used with error_set() and qerror_report(), and expand into the
> first *two* arguments.  This trickiness has become pointless.  Clean
> up QERR_DEVICE_ENCRYPTED and QERR_DEVICE_NOT_ENCRYPTED.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>   block.c                   | 5 +++--
>   include/qapi/qmp/qerror.h | 6 ------
>   2 files changed, 3 insertions(+), 8 deletions(-)

Reviewed-by: Max Reitz <address@hidden>