[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH v1 09/13] acpi, piix4: Add memory hot unp
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [RESEND PATCH v1 09/13] acpi, piix4: Add memory hot unplug support for piix4. |
Date: |
Thu, 29 Jan 2015 13:55:04 +0100 |
On Thu, 8 Jan 2015 09:06:16 +0800
Tang Chen <address@hidden> wrote:
> Call memory unplug cb in piix4_device_unplug_cb().
> ---
> hw/acpi/piix4.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
> index f809c3a..4ae4867 100644
> --- a/hw/acpi/piix4.c
> +++ b/hw/acpi/piix4.c
> @@ -377,8 +377,16 @@ static void
> piix4_device_unplug_request_cb(HotplugHandler *hotplug_dev,
> static void piix4_device_unplug_cb(HotplugHandler *hotplug_dev,
> DeviceState *dev, Error **errp)
> {
> - error_setg(errp, "acpi: device unplug for not supported device"
> - " type: %s", object_get_typename(OBJECT(dev)));
> + PIIX4PMState *s = PIIX4_PM(hotplug_dev);
> +
> + if (s->acpi_memory_hotplug.is_enabled &&
is above check really necessary? If yes, do it inside common
acpi_memory_unplug_cb()
> + object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
> + acpi_memory_unplug_cb(&s->ar, s->irq, &s->acpi_memory_hotplug,
> + dev, errp);
> + } else {
> + error_setg(errp, "acpi: device unplug for not supported device"
> + " type: %s", object_get_typename(OBJECT(dev)));
> + }
> }
>
> static void piix4_update_bus_hotplug(PCIBus *pci_bus, void *opaque)
- [Qemu-devel] [RESEND PATCH v1 03/13] acpi, mem-hotplug: Add acpi_memory_hotplug_sci() to rise sci for memory hotplug., (continued)
- [Qemu-devel] [RESEND PATCH v1 03/13] acpi, mem-hotplug: Add acpi_memory_hotplug_sci() to rise sci for memory hotplug., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 04/13] acpi, mem-hotplug: Add unplug request cb for memory device., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 05/13] acpi, piix4: Add memory hot unplug request support for piix4., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 06/13] acpi, ich9: Add memory hot unplug request support for ich9., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 08/13] acpi, mem-hotplug: Add unplug cb for memory device., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 07/13] pc-dimm: Add memory hot unplug request support for pc-dimm., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 09/13] acpi, piix4: Add memory hot unplug support for piix4., Tang Chen, 2015/01/07
- Re: [Qemu-devel] [RESEND PATCH v1 09/13] acpi, piix4: Add memory hot unplug support for piix4.,
Igor Mammedov <=
- [Qemu-devel] [RESEND PATCH v1 10/13] acpi, ich9: Add memory hot unplug support for ich9., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 11/13] pc-dimm: Add memory hot unplug support for pc-dimm., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 12/13] acpi: Add hardware implementation for memory hot unplug., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 13/13] pc, acpi bios: Add memory hot unplug interface., Tang Chen, 2015/01/07
- Re: [Qemu-devel] [RESEND PATCH v1 00/13] QEmu memory hot unplug support., Igor Mammedov, 2015/01/29