[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/9] qmp hmp: Improve error messages when SPICE i
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 2/9] qmp hmp: Improve error messages when SPICE is not in use |
Date: |
Thu, 29 Jan 2015 10:27:31 +0100 |
Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose,
probably because adding another error seemed cumbersome overkill.
Produces "No spice device has been activated", which is awkward.
We've since abandoned our quest for "rich" error objects. Time to
undo the damage to this error message. Replace it by "SPICE is not in
use".
Keep the stupid DeviceNotActive ErrorClass for compatibility, even
though Libvirt doesn't use it.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
---
include/ui/qemu-spice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h
index db7926d..762e063 100644
--- a/include/ui/qemu-spice.h
+++ b/include/ui/qemu-spice.h
@@ -91,8 +91,8 @@ static inline int qemu_spice_display_add_client(int csock,
int skipauth,
static inline bool qemu_using_spice(Error **errp)
{
if (!using_spice) {
- /* correct one? spice isn't a device ,,, */
- error_set(errp, QERR_DEVICE_NOT_ACTIVE, "spice");
+ error_set(errp, ERROR_CLASS_DEVICE_NOT_ACTIVE,
+ "SPICE is not in use");
return false;
}
return true;
--
1.9.3
- [Qemu-devel] [PATCH v2 0/9] qmp hmp balloon: Cleanups around error reporting, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 2/9] qmp hmp: Improve error messages when SPICE is not in use,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 9/9] balloon: Eliminate silly QERR_ macros, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 5/9] qmp: Simplify recognition of capability negotiation command, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 7/9] balloon: Inline qemu_balloon(), qemu_balloon_status(), Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 4/9] qmp: Clean up qmp_query_spice() #ifndef !CONFIG_SPICE dummy, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 6/9] qmp: Eliminate silly QERR_COMMAND_NOT_FOUND macro, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 8/9] balloon: Factor out common "is balloon active" test, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 3/9] hmp: Compile hmp_info_spice() only with CONFIG_SPICE, Markus Armbruster, 2015/01/29
- [Qemu-devel] [PATCH v2 1/9] qmp hmp: Factor out common "using spice" test, Markus Armbruster, 2015/01/29