[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND 44/50] block: Inquire tray state before t
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RESEND 44/50] block: Inquire tray state before tray-moved events |
Date: |
Wed, 28 Jan 2015 13:37:13 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/27/2015 12:46 PM, Max Reitz wrote:
> blk_dev_change_media_cb() is called for all potential tray movements;
> however, it is possible to request closing the tray but nothing actually
> happening (on a floppy disk drive without a medium).
>
> Thus, the actual tray status should be inquired before sending a
> tray-moved event (and an event should be sent whenever the status
> changed).
>
> Checking @load is now superfluous; it was necessary because it was
> possible to change a medium without having explicitly opened the tray
> and closed it again (or it might have been possible, at least). This is
> no longer possible, though.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/block-backend.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH RESEND 45/50] qmp: Introduce blockdev-change-medium, (continued)
- [Qemu-devel] [PATCH RESEND 42/50] blockdev: Implement eject with basic operations, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 43/50] blockdev: Implement change with basic operations, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 47/50] blockdev: Add read-only option to blockdev-change-medium, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 44/50] block: Inquire tray state before tray-moved events, Max Reitz, 2015/01/27
- Re: [Qemu-devel] [PATCH RESEND 44/50] block: Inquire tray state before tray-moved events,
Eric Blake <=
- [Qemu-devel] [PATCH RESEND 49/50] iotests: More options for VM.add_drive(), Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 50/50] iotests: Add test for change-related QMP commands, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 48/50] hmp: Add read-only option to change command, Max Reitz, 2015/01/27