Re: [Qemu-devel] [PATCH RESEND 38/50] blockdev: Add blockdev-open-tray

[Max Reitz]

On 2015-01-28 at 14:56, Eric Blake wrote:
> On 01/27/2015 12:46 PM, Max Reitz wrote:
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >   blockdev.c           | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >   qapi/block-core.json | 21 +++++++++++++++++++++
> >   qmp-commands.hx      | 37 +++++++++++++++++++++++++++++++++++++
> >   3 files changed, 106 insertions(+)
> >
> > +Example (1):
> > +
> With only one example, the (1) doesn't add much.  Minor whether you
> leave it in or take it out.

I'll remove it.

Max

> > +-> { "execute": "blockdev-open-tray",
> > +     "arguments": { "device": "ide1-cd0" } }
> > +
> > +<- { "timestamp": { "seconds": 1418751016,
> > +                    "microseconds": 716996 },
> > +     "event": "DEVICE_TRAY_MOVED",
> > +     "data": { "device": "ide1-cd0",
> > +               "tray-open": true } }
> > +
> > +<- { "return": {} }
> Nice inclusion of the event alongside the return code!
>
> Reviewed-by: Eric Blake <address@hidden>