[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into Bl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into BlockBackend |
Date: |
Tue, 27 Jan 2015 13:31:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
[replies to earlier patches in the other thread; moving the rest of my
review here for the sake of improved cc]
On 01/27/2015 12:45 PM, Max Reitz wrote:
> As the comment above bdrv_get_stats() says, BlockAcctStats is something
> which belongs to the device instead of each BlockDriverState. This patch
> therefore moves it into the BlockBackend.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 11 -----------
> block/block-backend.c | 5 ++++-
> block/qapi.c | 20 ++++++++++++--------
> include/block/block.h | 2 --
> include/block/block_int.h | 3 ---
> 5 files changed, 16 insertions(+), 25 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
(I spent some time hunting to ensure that 0-initialized stats make sense
when there is no BB - libvirt returns -1 rather than 0 for some stats,
but it's always a pain to remember which stats have the special treatment)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RESEND 00/50] blockdev: BlockBackend and media, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 04/50] hw/usb-storage: Check whether BB is inserted, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 05/50] block: Fix BB AIOCB AioContext without BDS, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 06/50] block: Add blk_is_available(), Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 07/50] block: Make bdrv_is_inserted() recursive, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 02/50] iotests: Only create BB if necessary, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 08/50] block/quorum: Implement bdrv_is_inserted(), Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/01/27
- Re: [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into BlockBackend,
Eric Blake <=
- [Qemu-devel] [PATCH RESEND 12/50] block: Move I/O status and error actions into BB, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 09/50] block: Move guest_block_size into BlockBackend, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 18/50] block: Respect empty BB in bdrv_query_info(), Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 16/50] block: Prepare remaining BB functions for NULL BDS, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 10/50] block: Remove wr_highest_offset from BlockAcctStats, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 19/50] blockdev: Use BlockBackend for blockdev-backup TA, Max Reitz, 2015/01/27