Re: [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files

[Max Reitz]

On 2015-01-27 at 08:51, Denis V. Lunev wrote:
> fallocate() works fine and could handle properly with arbitrary size
> requests.

Maybe "could properly handle arbitrary size requests" (or 
"...arbitrarily sized requests")?

> There is no sense to reduce the amount of space to fallocate.
> The bigger is the size, the better is the performance as the amount of
> journal updates is reduced.

True for fallocate(). But is it true for xfs_write_zeroes(), too? I 
guess so, but I don't know.

If it does, the patch looks good to me.

Max

> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Peter Lieven <address@hidden>
> CC: Fam Zheng <address@hidden>
> ---
>   block/raw-posix.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)