[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machin
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine |
Date: |
Tue, 27 Jan 2015 15:37:14 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 |
On 27.01.2015 11:09, Peter Maydell wrote:
> On 27 January 2015 at 09:24, Claudio Fontana <address@hidden> wrote:
>> On 22.01.2015 16:52, Alexander Graf wrote:
>>> On 22.01.15 16:28, Claudio Fontana wrote:
>>>> Alex wrote;
>>>>> + for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
>>>>
>>>> devfn += 0x8 (spaces)
>>>
>>> Yeah, I had it like that and it looked uglier. I guess it's a matter of
>>> personal preference?
>>
>> You don't have coding standards for this ?
>
> Not formal ones, but (a) I think += should have spaces aronud
> it and (b) I'm a bit surprised if checkpatch doesn't catch
> this (it certainly attempts to...)
>
> -- PMM
It does:
ERROR: spaces required around that '+=' (ctx:VxV)
#167: FILE: hw/arm/virt.c:571:
+ for (devfn = 0; devfn <= 0x18; devfn+=0x8) {
^
Claudio
Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine, Peter Maydell, 2015/01/27
- Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine, Alexander Graf, 2015/01/29
- Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine, Peter Maydell, 2015/01/29
- Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine, Alexander Graf, 2015/01/29
- Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine, Peter Maydell, 2015/01/29
- Re: [Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine, Alexander Graf, 2015/01/29
[Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge, Alexander Graf, 2015/01/21