[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 42/50] blockdev: Implement eject with basic operatio
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 42/50] blockdev: Implement eject with basic operations |
Date: |
Mon, 26 Jan 2015 11:03:16 -0500 |
Implement 'eject' by calling blockdev-open-tray and
blockdev-remove-medium.
Signed-off-by: Max Reitz <address@hidden>
---
blockdev.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index e4588b3..0b204eb 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1865,15 +1865,15 @@ out:
void qmp_eject(const char *device, bool has_force, bool force, Error **errp)
{
- BlockBackend *blk;
+ Error *local_err = NULL;
- blk = blk_by_name(device);
- if (!blk) {
- error_set(errp, QERR_DEVICE_NOT_FOUND, device);
+ qmp_blockdev_open_tray(device, has_force, force, &local_err);
+ if (local_err) {
+ error_propagate(errp, local_err);
return;
}
- eject_device(blk, force, errp);
+ qmp_blockdev_remove_medium(device, errp);
}
void qmp_block_passwd(bool has_device, const char *device,
--
2.1.0
- [Qemu-devel] [PATCH 30/50] blockdev: Check BB validity in change-backing-file, (continued)
- [Qemu-devel] [PATCH 30/50] blockdev: Check BB validity in change-backing-file, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 37/50] block: Add blk_remove_bs(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 36/50] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 35/50] blockdev: Pull out blockdev option extraction, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 43/50] blockdev: Implement change with basic operations, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 44/50] block: Inquire tray state before tray-moved events, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 39/50] blockdev: Add blockdev-close-tray, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 38/50] blockdev: Add blockdev-open-tray, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 40/50] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 49/50] iotests: More options for VM.add_drive(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 42/50] blockdev: Implement eject with basic operations,
Max Reitz <=
- [Qemu-devel] [PATCH 45/50] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 41/50] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 46/50] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 47/50] blockdev: Add read-only option to blockdev-change-medium, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 50/50] iotests: Add test for change-related QMP commands, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 48/50] hmp: Add read-only option to change command, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 00/50] blockdev: BlockBackend and media, Eric Blake, 2015/01/27
- Re: [Qemu-devel] [PATCH 00/50] blockdev: BlockBackend and media, Max Reitz, 2015/01/27