Re: [Qemu-devel] [PATCH 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags

[Peter Maydell]

On 24 January 2015 at 19:31, Peter Maydell <address@hidden> wrote:
> On 24 January 2015 at 16:36, Greg Bellows <address@hidden> wrote:
>> I understand what the code is doing, my point is that you rely on
>> arm_is_secure_below_el3 to deal with EL2 when you could have just as easily
>> checked for el<2.  Not a big deal though.
>
> Well, I rely on the architecture to tell me that it isn't
> possible for arm_is_secure_below_el3 to be true if we're
> in EL2. Otherwise there'd be a bug in that function...

On reflection, I see your point, so have changed to 'el < 2 && ...'
for v2.

thanks
-- PMM