Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other

[Peter Maydell]

On 25 January 2015 at 12:06, Chen Gang S <address@hidden> wrote:
> lock_user_struct() and unlock_user_struct() need always be paired with
> each other, or will cause resource leak.
>
> Also remove redundant check for 'target_mb' in abi_long do_msgrcv().
>
> Also match the coding styles found by "./scripts/checkpatch.pl".
>
> Signed-off-by: Chen Gang <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

Are you claiming that you've reviewed *all* the code in this
file for mismatched lock/unlock calls? If so, it would be nice
to say so explicitly in the commit message. If not, it would be
nice if the commit message was clearer about what areas of the
code it applied to. The code changes are correct, though.

thanks
-- PMM