[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/4] qemu-io: initialize progname with error_set_
From: |
Hitoshi Mitake |
Subject: |
[Qemu-devel] [PATCH v2 1/4] qemu-io: initialize progname with error_set_progname() |
Date: |
Thu, 22 Jan 2015 18:08:11 +0900 |
Calling error_get_progname() in the context of qemu-io can cause
segmentation fault because qemu-io doesn't initialize its progname
with error_set_progname(). This patch adds the initialization.
Currently, the missing call of error_set_progname() doesn't cause any
problems because qemu-io doesn't use error_get_progname(). This patch
is a proactive action.
Cc: Kevin Wolf <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Hitoshi Mitake <address@hidden>
---
qemu-io.c | 1 +
1 file changed, 1 insertion(+)
v2:
- pass argv[0] directly to error_set_progname() without calling basename
diff --git a/qemu-io.c b/qemu-io.c
index 91a445a..0e7d7d4 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -396,6 +396,7 @@ int main(int argc, char **argv)
progname = basename(argv[0]);
qemu_init_exec_dir(argv[0]);
+ error_set_progname(argv[0]);
bdrv_init();
--
1.9.1