Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

[Peter Maydell]

On 20 January 2015 at 09:59, Markus Armbruster <address@hidden> wrote:
> Commit fecd264 added a number of fall-throughs, but neglected to
> properly document them as intentional.  Commit d922445 cleaned that up
> for many, but not all cases.  Take care of the remaining ones.
>
> Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  target-mips/translate.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index e9d86b2..8abc12b 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -18729,6 +18729,7 @@ static void decode_opc(CPUMIPSState *env, 
> DisasContext *ctx)
>      case OPC_SWL:
>      case OPC_SWR:
>          check_insn_opc_removed(ctx, ISA_MIPS32R6);
> +         /* fall through */

Indent here seems to be out by one? The others look OK.

-- PMM