[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-arm: Split NO_MIGRATE into ALIAS and
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-arm: Split NO_MIGRATE into ALIAS and NO_RAW |
Date: |
Mon, 19 Jan 2015 18:47:58 +0000 |
On 19 January 2015 at 17:19, Greg Bellows <address@hidden> wrote:
>> { .name = "ELR_EL1", .state = ARM_CP_STATE_AA64,
>> - .type = ARM_CP_NO_MIGRATE,
>> + .type = ARM_CP_ALIAS,
>> .opc0 = 3, .opc1 = 0, .crn = 4, .crm = 0, .opc2 = 1,
>> .access = PL1_RW,
>> .fieldoffset = offsetof(CPUARMState, elr_el[1]) },
>> { .name = "SPSR_EL1", .state = ARM_CP_STATE_AA64,
>> - .type = ARM_CP_NO_MIGRATE,
>> + .type = ARM_CP_ALIAS,
>> .opc0 = 3, .opc1 = 0, .crn = 4, .crm = 0, .opc2 = 0,
>> .access = PL1_RW, .fieldoffset = offsetof(CPUARMState,
>> banked_spsr[0]) },
>
>
> From what I can tell, the SPSR and ELR regs are handled specially as I
> couldn't find the non-alias equivalents? If this is true it may be worth a
> comment.
They're aliases because they're handled by machine.c separately
(not being in the cp15 substruct). It's always been that way,
so I don't think it needs a comment in this patch...
PS: comic sans on an open source mailing list? You might want
to fix your mail client settings :-) (plain text is the usual
recommendation).
-- PMM
[Qemu-devel] [PATCH 1/2] target-arm: Split NO_MIGRATE into ALIAS and NO_RAW, Peter Maydell, 2015/01/19