[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] pci: Partial conversion to realize
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] pci: Partial conversion to realize |
Date: |
Mon, 19 Jan 2015 17:00:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Hi Markus,
>
> Am 19.01.2015 um 15:52 schrieb Markus Armbruster:
>> I posted this series as RFC back in October, but it depended on
>> patches then still under review, so I put it aside, and promptly
>> forgot. Fortunately, rebasing and updating it wasn't much trouble.
>
> A question I had brought up for the RFC was that of testing: Did you
> check which of your conversions are covered by QTest or where we may
> first need additional test cases to verify this doesn't regress?
>
> As a reminder, when converting ISA devices, I accepted patches that were
> only tested with one of two serial devices contained in a file, promptly
> breaking the other in some target. I'd like to avoid that for PCI. ;)
I got this after I sent my reply to your original question.
Perhaps we could create a qtest that tries to -device every known PCI
device: grab them from
{ "execute": "qom-list-types", "arguments": { "implements": "pci-device" } }
Some require properties, typically backends. We could introspect with
device-list-properties and try to supply common ones, like "drive",
"chardev", "netdev".
Doing it as a big device_add / device_del orgy would be cute, except
device_del requires guest cooperation, complicating the test. We could
special-case device_del before guest starts if we wanted.
- [Qemu-devel] [PATCH 04/10] pcnet: pcnet_common_init() always returns 0, change to void, (continued)
- [Qemu-devel] [PATCH 04/10] pcnet: pcnet_common_init() always returns 0, change to void, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 07/10] ide/ich: Convert to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 09/10] qxl: Convert to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 01/10] pci: Convert core to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 06/10] serial-pci: Convert to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 10/10] pci-assign: Convert to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 03/10] pci: Trivial device model conversions to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 08/10] cirrus-vga: Convert to realize, Markus Armbruster, 2015/01/19
- [Qemu-devel] [PATCH 05/10] pcnet: Convert to realize, Markus Armbruster, 2015/01/19
- Re: [Qemu-devel] [PATCH 00/10] pci: Partial conversion to realize, Andreas Färber, 2015/01/19
- Re: [Qemu-devel] [PATCH 00/10] pci: Partial conversion to realize,
Markus Armbruster <=