[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian host
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts |
Date: |
Tue, 13 Jan 2015 16:48:30 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jan 07, 2015 at 06:39:12PM +0100, Paolo Bonzini wrote:
> This was accessing an XMM register's low half without going through XMM_Q.
>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-i386/translate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index ebdc350..5af4300 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -3074,7 +3074,8 @@ static void gen_sse(CPUX86State *env, DisasContext *s,
> int b,
> goto illegal_op;
> gen_lea_modrm(env, s, modrm);
> if (b1 & 1) {
> - gen_stq_env_A0(s, offsetof(CPUX86State, xmm_regs[reg]));
> + gen_stq_env_A0(s, offsetof(CPUX86State,
> + xmm_regs[reg].XMM_Q(0)));
Do we have (or will patch 4/4 introduce) the same bug on the
tcg_gen_addi_ptr() calls that don't use the XMM_Q macro?
--
Eduardo
[Qemu-devel] [PATCH 4/4] target-i386: make xmm_regs 512-bit wide, Paolo Bonzini, 2015/01/07
[Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs, Paolo Bonzini, 2015/01/07
[Qemu-devel] [PATCH 3/4] target-i386: use vmstate_offset_sub_array for AVX registers, Paolo Bonzini, 2015/01/07