Re: [Qemu-devel] [PATCH v3 0/5] libqos: Virtio MMIO driver

[Stefan Hajnoczi]

On Wed, Dec 3, 2014 at 9:31 AM, Marc Marí <address@hidden> wrote:
> Add virtio-mmio support to libqos and test case for virtio-blk.
>
> This series depends on patch "libqos: Convert malloc-pc allocator to a generic
> allocator"
>
> Changes from version 2:
>  - Fix leaks and minor bugs
>  - Extract basic test case to a function
>
> Marc Marí (5):
>   libqos: Change use of pointers to uint64_t in virtio
>   tests: Prepare virtio-blk-test for multi-arch implementation
>   libqos: Remove PCI assumptions in constants of virtio driver
>   libqos: Add malloc generic
>   libqos: Add virtio MMIO support
>
>  tests/Makefile                |    4 +-
>  tests/libqos/malloc-generic.c |   50 +++++++++
>  tests/libqos/malloc-generic.h |   21 ++++
>  tests/libqos/virtio-mmio.c    |  190 +++++++++++++++++++++++++++++++
>  tests/libqos/virtio-mmio.h    |   46 ++++++++
>  tests/libqos/virtio-pci.c     |   50 +++++----
>  tests/libqos/virtio-pci.h     |   24 ++--
>  tests/libqos/virtio.c         |    8 +-
>  tests/libqos/virtio.h         |   16 +--
>  tests/virtio-blk-test.c       |  249 
> ++++++++++++++++++++++++++++-------------
>  10 files changed, 534 insertions(+), 124 deletions(-)
>  create mode 100644 tests/libqos/malloc-generic.c
>  create mode 100644 tests/libqos/malloc-generic.h
>  create mode 100644 tests/libqos/virtio-mmio.c
>  create mode 100644 tests/libqos/virtio-mmio.h

Hi Marc,
Peter Maydell hit two issues with this series when running "make
check" under arm-softmmu.

I had to drop this series.


1. The raw format probing warnings, which were recently introduced to
warn users when opening a raw file without -drive format=raw.

Quoting Peter:
(1) Ugly warning (seems to happen everywhere):

TEST: tests/virtio-blk-test... (pid=28666)
  /arm/virtio/blk/mmio/basic:
WARNING: Image format was not specified for '/tmp/qtest.q0ywpl' and
probing guessed raw.
         Automatically detecting the format is dangerous for raw
images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
OK

Solution:
In the arm_basic virtio-mmio test, make sure to use -drive ...,format=raw.


2. The qvirtio_wait_queue_isr() timeout is hit (30 seconds?!)
sometimes.  Not sure why this happens, this needs investigation.

Quoting Peter:
TEST: tests/virtio-blk-test... (pid=16564)
  /arm/virtio/blk/mmio/basic:
WARNING: Image format was not specified for '/tmp/qtest.4s4Naf' and
probing guessed raw.
         Automatically detecting the format is dangerous for raw
images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
**
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqos/virtio.c:91:qvirtio_wait_queue_isr:
assertion failed: (g_get_monotonic_time() - start_time <= timeout_us)
FAIL
GTester: last random seed: R02S2b2c6e34351d711919b868b92fde3543
(pid=16570)
FAIL: tests/virtio-blk-test

This might be an intermittent failure; I think my x86-64 gcc
build passed the first time and failed on a rerun. The clang
build also failed this.

Stefan