Re: [Qemu-devel] [PATCH v2] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

[Gerd Hoffmann]

  Hi,

> +    /* Determines the pixel format of the frame buffer */
> +    if (surface->format == PIXMAN_b8g8r8x8) {
> +        bitmap_info = kCGBitmapByteOrder32Big | kCGImageAlphaNoneSkipFirst;
> +    }

That certainly goes into the right direction.

PIXMAN_* is native endian though, so I expect this will work on the
intel macos host you are testing on but will fail on powerpc macos
hosts.

I suggest to add fixed endian defines for 32bpp to
include/ui/qemu-pixman.h (there already is one for 24bpp), then use
these to avoid cluttering the cocoa code with HOST_WORDS_BIGENDIAN
#defines.

The colorspace bits look sane to me, I'm not macos x expert enough to
really justify.

cheers,
  Gerd