Re: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

[Gerd Hoffmann]

On Do, 2015-01-08 at 11:50 +0100, Javier Celaya wrote:
> Hello
> 
> Recently, SPICE included the lz4 compression algorithm. This patch adds
> a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not 
> exist before the commit that added this compression algorithm, so it should 
> be 
> guarded with conditional compilation. How do you think this should be done? 
> Wait for the next stable version of spice-server and check for 
> SPICE_SERVER_VERSION? Or add a specific flag?

Given that SPICE_IMAGE_COMPRESS_LZ4 is a enum not define (so you can't
just #ifdef SPICE_IMAGE_COMPRESS_LZ4) using SPICE_SERVER_VERSION looks
best to me.

cheers,
  Gerd