Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

[Paolo Bonzini]

On 07/01/2015 12:03, Marcel Apfelbaum wrote:
> 
> While I agree it will be better if we place this in instance_init,
> setting the machine_usb to defaults_enabled() there would be problematic
> since it depends on
>  - papr_vga_init(phb->bus) for sparpr and

That's effectively vga_interface_type == VGA_DEVICE ||
vga_interface_type == VGA_STD.

>  - (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) for mac99.
>    (The env itself is set in machine_init)

Alex, why is auto-USB disabled for 6xx?  Can it use vga_interface_type
like spapr does?

Paolo

> Both of those conditions may be available only at machine_init time,
> and I am not sure how it would affect those machines.