[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support |
Date: |
Tue, 6 Jan 2015 15:19:11 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jan 05, 2015 at 06:24:59PM -0800, address@hidden wrote:
> From: Scott Feldman <address@hidden>
>
> Add QMP/HMP support for rocker devices. This is mostly for debugging purposes
> to see inside the device's tables and port configurations. Some examples:
>
> (qemu) rocker sw1
> name: sw1
> id: 0x0000013512005452
> ports: 4
The convention is for HMP commands that show information to be "info"
sub-commands. So this example would be "info rocker sw1". See
monitor.c:info_cmds[].
The convention for QMP is to call the command "query-rocker".
>
> (qemu) rocker-ports sw1
> ena/ speed/ auto
> port link duplex neg?
> sw1.1 up 10G FD No
> sw1.2 up 10G FD No
> sw1.3 !ena 10G FD No
> sw1.4 !ena 10G FD No
HMP: info rocker-ports sw1
QMP: query-rocker-ports
and so on.
> +##
> +# @RockerOfDpaFlow:
> +#
> +# Rocker switch OF-DPA flow
> +#
> +# @cookie: flow unique cookie ID
> +#
> +# @hits: count of matches (hits) on flow
> +#
> +# @key: flow key
> +#
> +# @mask: flow mask
> +#
> +# @action: flow action
> +##
For versioning, the schema should mention which QEMU release a command
was added in:
# Since: 2.3
That way QAPI consumers can plan accordingly and be aware when older
QEMU binaries may not implement a command.
pgp7NB3p2sMiE.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v2 05/10] pci: add rocker device ID, (continued)
- [Qemu-devel] [PATCH v2 05/10] pci: add rocker device ID, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 00/10] rocker: add new rocker ethernet switch device, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 02/10] net: add MAC address string printer, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 06/10] pci: add network device class 'other' for network switches, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 04/10] rocker: add register programming guide, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 10/10] MAINTAINERS: add rocker, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 09/10] rocker: add tests, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support, sfeldma, 2015/01/05
- Re: [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device, sfeldma, 2015/01/05