Re: [Qemu-devel] [PATCH] Fixes fullscreen aspect ratio and leaving fullscreen mode problem on Mac OS X

[Peter Maydell]

On 1 January 2015 at 16:05, Programmingkid <address@hidden> wrote:
>
> On Jan 1, 2015, at 9:55 AM, Peter Maydell wrote:
>
>> On 30 December 2014 at 04:17, Programmingkid <address@hidden> wrote:
>>> This patch fixes these problems for QEMU on Mac OS X:
>>> - fullscreen mode not having the correct aspect ratio
>>
>> What is the bug being fixed here? For me on 10.9.5 the fullscreen
>> behaviour is the same with or without this patch: the fullscreen
>> window is of the same size as the non-fullscreened version, with
>> a plain background behind it, so there's no aspect ratio issue.
>> I'm guessing that 10.6 behaved differently (the Lion fullscreen
>> changes were pretty drastic).
>
> When you look at the openbios prompt in full screen mode, you can
> see the text is all messed up looking. That is because the aspect
> ratio isn't being preserved.

So is it actually expanding the window to fill the whole of the
screen, rather than keeping it at the same resolution but just
the only window being displayed? That's definitely different from
the Lion-and-up behaviour...

>> and there are other problems with fullscreen still -- for instance
>> if you fullscreen the window before the guest changes its
>> resolution and then unfullscreen it afterwards, we forget about
>> the fact the resolution changed and revert to the pre-change size.
>
> I haven't noticed this issue. Which machine emulator are you using?

I use vexpress-a15, where it's quite easy to see because the
screen resolution changes a little way into kernel bootup,
so it's easy to fullscreen it before it gets there. You can
also see this with qemu-system-ppc if you're quick about hitting
the fullscreen button before it resizes. (In that case the
behaviour is different -- we fail to change the size of the
fullscreened window, so the openbios prompt isn't visible, and
switching back out of fullscreen it's still just a plain
yellow screen.)

http://people.linaro.org/~peter.maydell/vexpress-3.8.tgz
is a guest image which should demonstrate this, I think.

>> Another oddity: on fullscreening, the window's titlebar remains
>> visible, up until the point where the guest changes its screen
>> resolution, at which point it disappears. I'm guessing we shouldn't
>> display it at all in fullscreen.
>
> When qemu-system-ppc goes full screen, the menubar disappears over here.

I didn't mean the menubar (which does disappear); I meant the
title bar. Screenshot:
http://www.chiark.greenend.org.uk/~pmaydell/misc/qemu-screenshot.png

> I haven't noticed any mouse coordinate problems on Mac OS 10.6.
> I will try my code out on other versions of Mac OS X to see if
> I can reproduce your issues.

If you have access to a Lion-or-later version that would
definitely be helpful.

thanks
-- PMM