[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Do not hang on full PTY
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Do not hang on full PTY |
Date: |
Mon, 29 Dec 2014 23:41:59 +0000 |
On 29 December 2014 at 20:27, Don Slutz <address@hidden> wrote:
> I was not sure on this being trivial also, but it looked like it could
> be to me. The uses of this FD all looked that they handle non-blocking.
Does g_io_channel_read_chars() definitely return G_IO_STATUS_NORMAL
(and not, say, G_IO_STATUS_AGAIN) for an attempted read on a non-blocking
fd with no data? Otherwise pty_chr_read() is going to call
pty_chr_state(chr, 0) which I think means "the other end has hung up"
and will take the fd out of the main loop's poll set.
thanks
-- PMM