qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: support target-to-host SCM_CREDENTI


From: Alex Suykov
Subject: Re: [Qemu-devel] [PATCH] linux-user: support target-to-host SCM_CREDENTIALS
Date: Tue, 23 Dec 2014 07:52:46 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Tue, Dec 23, 2014 at 09:59:57AM +0800, Fam Zheng wrote:

> On Sun, 12/21 13:02, Alex Suykov wrote:
> > When passing ancillary data through a unix socket, handle
> > credentials properly instead of doing a simple copy and
> > issuing a warning.
> > 
> > Signed-off-by: Alex Suykov <address@hidden>
> > ---
...
> > -            gemu_log("Unsupported ancillary data: %d/%d\n", 
> > cmsg->cmsg_level, cmsg->cmsg_type);
...
> > +            gemu_log("Unsupported ancillary data: %d/%d\n", 
> > cmsg->cmsg_level, cmsg->cmsg_type);
...
> 
> I didn't review the code but checkpatch.pl complains about a few lines over 80
> characters.

The patch does not change the length of the longest line in that function,
just moves it around. So my guess was that mixing semantic changes
and reformatting is not a good idea.

Sending checkpatch-compliant v2.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]