[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 0/7] s390x patches for 2.3
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL v2 0/7] s390x patches for 2.3 |
|
Date: |
Sat, 20 Dec 2014 22:03:34 +0000 |
On 18 December 2014 at 16:34, Cornelia Huck <address@hidden> wrote:
> Next try for s390x updates. The previous build failures should be
> fixed now.
Still not building on w32, I'm afraid. I think most of this is run-on
error from using __uint16_t &c rather than uint16_t &c.
You also have a bunch of 64 bit constants like the ZPCI_*_ADDR
which need a trailing "ULL", and also some with a "UL" which
should probably be "ULL". For instance in
#define ZPCI_STE_FLAG_MASK 0x7ffUL
#define ZPCI_STE_ADDR_MASK (~ZPCI_STE_FLAG_MASK)
though ZPCI_STE_FLAG_MASK is OK by itself, when you use it
in ZPCI_STE_ADDR_MASK you will get the logical-negate done
at 32 bits before zero-extend to 64 bits, rather than a 64
bit negate.
(I think that "UL" is almost never correct in QEMU -- you
either want "at least 32 bits", in which case "U" is
sufficient, or you need "64 bits", in which case you need
"ULL".)
Some of those suffixes are provoking compiler warnings or
errors below, but some of them will just be silent wrong
behaviour, so you should probably eyeball the #defines...
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:14:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:25:
error: expected specifier-qualifier-list before ‘__uint16_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:30:
error: expected specifier-qualifier-list before ‘__uint16_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:55:
error: expected specifier-qualifier-list before ‘__uint16_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:92:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:101:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:114:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:124:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:145:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:156:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:176:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:188:
error: expected specifier-qualifier-list before ‘__uint32_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:257:
error: expected specifier-qualifier-list before ‘__uint8_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c: In
function ‘s390_translate_iommu’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c:322:
warning: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c: In
function ‘list_pci’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:43:
error: ‘ClpReqHdr’ has no member named ‘len’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:49:
error: ‘ClpReqListPci’ has no member named ‘fmt’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:55:
error: ‘ClpReqListPci’ has no member named ‘fmt’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:56:
error: ‘ClpReqListPci’ has no member named ‘reserved1’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:57:
error: ‘ClpReqListPci’ has no member named ‘reserved2’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:63:
error: ‘ClpReqListPci’ has no member named ‘resume_token’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:74:
error: ‘ClpRspHdr’ has no member named ‘len’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:80:
error: ‘ClpRspHdr’ has no member named ‘len’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:82:
warning: division by zero
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:89:
error: ‘ClpRspListPci’ has no member named ‘fmt’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:90:
error: ‘ClpRspListPci’ has no member named ‘reserved1’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:91:
error: ‘ClpRspListPci’ has no member named ‘reserved2’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:92:
error: ‘ClpRspListPci’ has no member named ‘mdd’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:93:
error: ‘ClpRspListPci’ has no member named ‘max_fn’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:94:
error: ‘ClpRspListPci’ has no member named ‘entry_size’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:104:
error: ‘ClpRspListPci’ has no member named ‘fh_list’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:106:
error: ‘ClpRspListPci’ has no member named ‘fh_list’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:108:
error: ‘ClpRspListPci’ has no member named ‘fh_list’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:109:
error: ‘ClpRspListPci’ has no member named ‘fh_list’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:110:
error: ‘ClpRspListPci’ has no member named ‘fh_list’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:128:
error: ‘ClpRspListPci’ has no member named ‘resume_token’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:129:
error: ‘ClpRspHdr’ has no member named ‘len’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:130:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:134:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c: In
function ‘clp_service_call’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:160:
error: ‘ClpReqHdr’ has no member named ‘len’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:168:
error: ‘ClpRspHdr’ has no member named ‘len’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:181:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:185:
error: ‘ClpReqHdr’ has no member named ‘cmd’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:195:
error: ‘ClpReqSetPci’ has no member named ‘fh’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:197:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:201:
error: ‘ClpReqSetPci’ has no member named ‘oc’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:204:
error: ‘ClpRspSetPci’ has no member named ‘fh’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:205:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:211:
error: ‘ClpRspSetPci’ has no member named ‘fh’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:212:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:216:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:225:
error: ‘ClpReqQueryPci’ has no member named ‘fh’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:228:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:236:
error: ‘ClpRspQueryPci’ has no member named ‘bar’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:237:
error: ‘ClpRspQueryPci’ has no member named ‘bar_size’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:245:
error: ‘ClpRspQueryPci’ has no member named ‘sdma’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:245:
warning: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:246:
error: ‘ClpRspQueryPci’ has no member named ‘edma’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:246:
warning: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:247:
error: ‘ClpRspQueryPci’ has no member named ‘pchid’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:248:
error: ‘ClpRspQueryPci’ has no member named ‘ug’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:249:
error: ‘ClpRspQueryPci’ has no member named ‘uid’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:250:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:255:
error: ‘ClpRspQueryPciGrp’ has no member named ‘fr’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:256:
error: ‘ClpRspQueryPciGrp’ has no member named ‘dasm’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:257:
error: ‘ClpRspQueryPciGrp’ has no member named ‘msia’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:257:
warning: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:258:
error: ‘ClpRspQueryPciGrp’ has no member named ‘mui’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:259:
error: ‘ClpRspQueryPciGrp’ has no member named ‘i’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:260:
error: ‘ClpRspQueryPciGrp’ has no member named ‘version’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:262:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:267:
error: ‘ClpRspHdr’ has no member named ‘rsp’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c: In
function ‘reg_irqs’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:605:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:610:
error: ‘ZpciFib’ has no member named ‘aisb’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:612:
error: ‘ZpciFib’ has no member named ‘aibv’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:614:
error: ‘ZpciFib’ has no member named ‘aisb’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:615:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:616:
error: ‘ZpciFib’ has no member named ‘aibv’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:617:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:618:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:619:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:620:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c: In
function ‘reg_ioat’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:648:
error: ‘ZpciFib’ has no member named ‘pba’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:649:
error: ‘ZpciFib’ has no member named ‘pal’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:650:
error: ‘ZpciFib’ has no member named ‘iota’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:654:
warning: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:654:
warning: integer constant is too large for ‘long’ type
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c: In
function ‘mpcifc_service_call’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:741:
error: ‘ZpciFib’ has no member named ‘fmb_addr’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c: In
function ‘stpcifc_service_call’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:780:
error: ‘ZpciFib’ has no member named ‘pba’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:781:
error: ‘ZpciFib’ has no member named ‘pal’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:782:
error: ‘ZpciFib’ has no member named ‘iota’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:783:
error: ‘ZpciFib’ has no member named ‘aibv’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:784:
error: ‘ZpciFib’ has no member named ‘aisb’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:785:
error: ‘ZpciFib’ has no member named ‘fmb_addr’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:790:
error: ‘ZpciFib’ has no member named ‘data’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:793:
error: ‘ZpciFib’ has no member named ‘fc’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:797:
error: ‘ZpciFib’ has no member named ‘fc’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:801:
error: ‘ZpciFib’ has no member named ‘fc’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:805:
error: ‘ZpciFib’ has no member named ‘fc’
make[1]: *** [hw/s390x/s390-pci-inst.o] Error 1
-- PMM
- [Qemu-devel] [PULL v2 0/7] s390x patches for 2.3, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 1/7] s390x/ccw: fix oddity in machine class init, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 5/7] s390: Add PCI bus support, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 2/7] s390x/css: Clean up unnecessary CONFIG_USER_ONLY wrappers, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 3/7] s390x/kvm: sync register support helper function, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 4/7] s390x/kvm: avoid syscalls by syncing registers with kvm_run, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 7/7] kvm: extend kvm_irqchip_add_msi_route to work on s390, Cornelia Huck, 2014/12/18
- [Qemu-devel] [PULL v2 6/7] s390: implement pci instructions, Cornelia Huck, 2014/12/18
- Re: [Qemu-devel] [PULL v2 0/7] s390x patches for 2.3,
Peter Maydell <=