[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 03/11] fw_cfg_mem: max access size and region siz
From: |
Laszlo Ersek |
Subject: |
[Qemu-devel] [PATCH v5 03/11] fw_cfg_mem: max access size and region size are the same for data register |
Date: |
Wed, 17 Dec 2014 22:10:05 +0100 |
Make it clear that the maximum access size to the MMIO data register
determines the full size of the memory region.
Currently the max access size is 1.
This patch doesn't change behavior.
Signed-off-by: Laszlo Ersek <address@hidden>
---
Notes:
v5:
- Remove the "fw_cfg_data_mem_ops.impl.max_access_size = 1"
initialization, because we won't ask the memory subsystem to split
accesses for us. [Paolo, Peter]
v4:
- unchanged
v3:
- new in v3 [Drew Jones]
hw/nvram/fw_cfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 880311c..5b4d9d4 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -30,9 +30,8 @@
#include "qemu/error-report.h"
#include "qemu/config-file.h"
#define FW_CFG_SIZE 2
-#define FW_CFG_DATA_SIZE 1
#define FW_CFG_NAME "fw_cfg"
#define FW_CFG_PATH "/machine/" FW_CFG_NAME
#define TYPE_FW_CFG "fw_cfg"
@@ -701,9 +700,10 @@ static void fw_cfg_mem_realize(DeviceState *dev, Error
**errp)
sysbus_init_mmio(sbd, &s->ctl_iomem);
sysbus_mmio_map(sbd, 0, s->ctl_addr);
memory_region_init_io(&s->data_iomem, OBJECT(s), &fw_cfg_data_mem_ops,
- FW_CFG(s), "fwcfg.data", FW_CFG_DATA_SIZE);
+ FW_CFG(s), "fwcfg.data",
+ fw_cfg_data_mem_ops.valid.max_access_size);
sysbus_init_mmio(sbd, &s->data_iomem);
sysbus_mmio_map(sbd, 1, s->data_addr);
}
--
1.8.3.1
- [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 02/11] fw_cfg: move boards to fw_cfg_init_io() / fw_cfg_init_mem(), Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 03/11] fw_cfg_mem: max access size and region size are the same for data register,
Laszlo Ersek <=
- [Qemu-devel] [PATCH v5 04/11] fw_cfg_mem: flip ctl_mem_ops and data_mem_ops to DEVICE_BIG_ENDIAN, Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 05/11] exec: allows 8-byte accesses in subpage_ops, Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 06/11] fw_cfg_mem: introduce the "data_width" property, Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 07/11] fw_cfg_mem: expose the "data_width" property with fw_cfg_init_mem_wide(), Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 08/11] arm: add fw_cfg to "virt" board, Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 09/11] hw/loader: split out load_image_gzipped_buffer(), Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 10/11] hw/arm: pass pristine kernel image to guest firmware over fw_cfg, Laszlo Ersek, 2014/12/17
- [Qemu-devel] [PATCH v5 11/11] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware, Laszlo Ersek, 2014/12/17
- Re: [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Paolo Bonzini, 2014/12/18
- Re: [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt, Gerd Hoffmann, 2014/12/19