qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.


From: Peter Maydell
Subject: Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.
Date: Tue, 16 Dec 2014 16:37:10 +0000

On 16 December 2014 at 09:13,  <address@hidden> wrote:
> From: KONRAD Frederic <address@hidden>
>
> This adds a lock to avoid multiple exclusive access at the same time in case 
> of
> TCG multithread.

This feels to me like it's not really possible to review on
its own, since you can't see how it fits into the design of
the rest of the multithreading support.

The other approach here rather than having a pile of mutexes
in the target-* code would be to have TCG IR support for
"begin critical section"/"end critical section". Then you
could have the main loop ensure that no other CPU is running
at the same time as the critical-section code. (linux-user
already has an ad-hoc implementation of this for the
exclusives.)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]