Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

[Frank Blaschka]

On Tue, Dec 16, 2014 at 12:56:58PM +0100, Alexander Graf wrote:
> 
> 
> On 16.12.14 12:46, Frank Blaschka wrote:
> > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote:
> >>
> >>
> >>
> >>> Am 16.12.2014 um 10:28 schrieb Frank Blaschka <address@hidden>:
> >>>
> >>> From: Frank Blaschka <address@hidden>
> >>>
> >>> Remove unnecessary and wrong includes. Fix get_rt_sto and
> >>> get_st_pto to build on 32-bit.
> >>>
> >>> Signed-off-by: Frank Blaschka <address@hidden>
> >>
> >> Could you please roll the fixes into the offending patches and repost the 
> >> set? Otherwise we break bisectability on 32bit hosts.
> >>
> > 
> > Sure, but since this is an initial drop and I have to touch the patches 
> > anyhow can I merge all
> > add-ons and fixes to the initial patch set?
> > 
> > I would like to end up finally with just 3 patches:
> > 
> >   s390: Add PCI bus support
> >   s390: implement pci instructions
> >   kvm: extend kvm_irqchip_add_msi_route to work on s390
> > 
> > If so I would post V2 of the initial patch set including all changes.
> 
> Cornelia is the maintainer here, so you'll need to ask her :). Anything
> that doesn't break bisectability is certainly better than code that
> breaks it.
>

OK. Coni what do you prefere?
 
> By squashing all those patches together you'll make bisecting harder for
> s390 - if you can live with it so can I.
> 
> 
> Alex
>