[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling |
|
Date: |
Mon, 15 Dec 2014 15:29:23 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Paolo Bonzini (address@hidden) wrote:
>
>
> On 15/12/2014 16:21, Dr. David Alan Gilbert wrote:
> >> >
> >> > - serial_xmit is called from outside only after resetting TEMT and THRE
> >> > and pushing a character on the FIFO
> > Are you sure about TEMT? My reading of serial_ioport_write is that if
> > !FCR_FE then TEMT isn't cleared.
>
> This patch changes that.
Oh yeh!
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v3 4/4] serial: only resample THR interrupt on rising edge of IER.THRI, (continued)