[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 12/26] qcow2: Open images with refcount order !=
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v5 12/26] qcow2: Open images with refcount order != 4 |
Date: |
Mon, 15 Dec 2014 13:50:43 +0100 |
No longer refuse to open images with a different refcount entry width
than 16 bits; only reject images with a refcount width larger than 64
bits (which is prohibited by the specification).
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index d14e7c4..e5105f1 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -677,10 +677,10 @@ static int qcow2_open(BlockDriverState *bs, QDict
*options, int flags,
}
/* Check support for various header values */
- if (header.refcount_order != 4) {
- report_unsupported(bs, errp, "%d bit reference counts",
- 1 << header.refcount_order);
- ret = -ENOTSUP;
+ if (header.refcount_order > 6) {
+ error_setg(errp, "Reference count entry width too large; may not "
+ "exceed 64 bits");
+ ret = -EINVAL;
goto fail;
}
s->refcount_order = header.refcount_order;
--
1.9.3
- [Qemu-devel] [PATCH v5 03/26] qcow2: Do not return new value after refcount update, (continued)
- [Qemu-devel] [PATCH v5 03/26] qcow2: Do not return new value after refcount update, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 04/26] qcow2: Only return status from qcow2_get_refcount, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 01/26] qcow2: Add two new fields to BDRVQcowState, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 06/26] qcow2: Use 64 bits for refcount values, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 07/26] qcow2: Respect error in qcow2_alloc_bytes(), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 05/26] qcow2: Use unsigned addend for update_refcount(), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes(), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 09/26] qcow2: Helper for refcount array reallocation, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 10/26] qcow2: Helper function for refcount modification, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount modification, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 12/26] qcow2: Open images with refcount order != 4,
Max Reitz <=
- [Qemu-devel] [PATCH v5 13/26] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 14/26] qcow2: Use symbolic macros in qcow2_amend_options, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 15/26] iotests: Prepare for refcount_bits option, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 16/26] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 17/26] progress: Allow regressing progress, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 18/26] block: Add opaque value to the amend CB, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 19/26] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 20/26] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 21/26] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/12/15
- [Qemu-devel] [PATCH v5 24/26] qcow2: Invoke refcount order amendment function, Max Reitz, 2014/12/15