Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

[Vladimir Sementsov-Ogievskiy]

Thanks. It's interesting that checkpatch.pl doesn't warn about this line.

Best regards,
Vladimir

On 11.12.2014 18:18, Eric Blake wrote:
> On 12/11/2014 07:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Add dirty parameter to qmp-migrate command. If this parameter is true,
> > block-migration.c will migrate dirty bitmaps. This parameter can be used
> > without "blk" parameter to migrate only dirty bitmaps, skipping block
> > migration.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---
> > +++ b/qapi-schema.json
> > @@ -1660,7 +1660,7 @@
> >   # Since: 0.14.0
> >   ##
> >   { 'command': 'migrate',
> > -  'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' } }
> > +  'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*dirty': 'bool', 
> > '*detach': 'bool' } }
> Missing documentation of the new option (including a mention of '(since
> 2.3)'.  Also, please keep lines shorter than 80 columns.