Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1

[Lokesha, Amulya]

Hi Max,

 

We applied all the 5 patches from the mail chain I got since the last week. Please find attached the patches used by us.

We were unable to apply the patch3 as it failed with the following error

 

# patch -p1 < patch3

patching file block/vhdx.c

patch: **** malformed patch at line 17:          error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB"); @@ -1936,7 +1936,9 @@ static QemuOptsList vhdx_create_opts = {

 

 

Hence, we manually added the patch3 changes and recompiled the qemu. We then used the patched qemu-img to convert  our vmdk image to dynamic VHDX format. We found that the image created this time had a considerable decrease in its size from 50GB to 12GB.

However, when we deployed it into our SCVMM 2012, the import of the VHDX image failed with a "syntax error" as below

 

Information (10804)

Unable to import \\Test.com\Library\VHDs\Test-disk1.vhdx because of a syntax error in the file.

 

Please let us know if we missed anything.

 

Thanks,

Amulya

 

-----Original Message-----
From: Max Reitz [mailto:address@hidden
Sent: Thursday, December 11, 2014 2:36 PM
To: Lokesha, Amulya; Jeff Cody; address@hidden
Cc: address@hidden; address@hidden
Subject: Re: [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1

 

On 2014-12-11 at 05:21, Lokesha, Amulya wrote:

> Hi,

> 

> I raised a bug https://bugs.launchpad.net/qemu/+bug/1399191 in the qemu bugzilla and immediately started getting these patch mails. But, I am not seeing any update in the bugzilla site.

> Till now I have got 4 patch mails regarding the issue. Please let me know which patch I should apply. Also let me know where can I get the patch files individually to be downloaded.

> 

> We are waiting for the patch to provide to our customers.

> 

> Thanks,

> Amulya

 

Hi Amulya,

 

Patches 3 and 4 are absolutely necessary for this issue; however, I would recommend to simply apply all patches of the series.

 

In order to download the patches you can simply save the patch emails and apply them with git am. If for some reason you don't want to use git, patch -p1 works as well.

 

Max

patch0.patch
Description: patch0.patch

patch1.patch
Description: patch1.patch

patch2.patch
Description: patch2.patch

patch3.patch
Description: patch3.patch

patch4.patch
Description: patch4.patch